Skip to content

cmake: reports: Fix puncover compatibility with v0.6.0 #97939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

cmake: reports: Fix puncover compatibility with v0.6.0 #97939

merged 1 commit into from
Oct 22, 2025
+1 −1

Conversation

@RoyAc6
Copy link
Contributor

@RoyAc6 RoyAc6 commented Oct 20, 2025 •
edited
Loading

Puncover v0.6.0 renamed the command-line argument
--gcc_tools_base to --gcc-tools-base.

Fixes compatibility error when running west build -t puncover with puncover v0.6.0 or newer.

Signed-off-by: Roy Jamil [email protected]

@github-actions
Copy link

Hello @RoyAc6, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added area: Build System size: XS A PR changing only a single line of code labels Oct 20, 2025
@RoyAc6 RoyAc6 changed the title scripts: puncover: Fix compatibility with v0.6.0 cmake: reports: Fix puncover compatibility with v0.6.0 Oct 20, 2025
@RoyAc6 RoyAc6 mentioned this pull request Oct 20, 2025
Open
@RoyAc6 RoyAc6 force-pushed the fix-puncover-v0.6.0 branch 2 times, most recently from 4cc803f to 48b2425 Compare October 21, 2025 16:30
@RoyAc6
scripts: puncover: Fix compatibility with v0.6.0
18e288f 
Signed-off-by: Roy Jamil <[email protected]>

Puncover v0.6.0 renamed the command-line argument
`--gcc_tools_base` to `--gcc-tools-base`.

Fixes compatibility error when running `west build -t puncover`
with puncover v0.6.0 or newer.
@RoyAc6 RoyAc6 force-pushed the fix-puncover-v0.6.0 branch from 48b2425 to 18e288f Compare October 21, 2025 16:46
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

tejlmand
tejlmand approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as the changes are correct, but technically the commit message is wrong:

Puncover v0.6.0 renamed the command-line argument
`--gcc_tools_base` to `--gcc-tools-base`.

Puncover v0.3.6 supported both --gcc-tools-base and --gcc_tools_base, so v0.6.0 just removed support for --gcc_tools_base.

This is important detail because it means that this change will not impact users having an older versions of puncover.

@cfriedt cfriedt merged commit 42e899d into zephyrproject-rtos:main Oct 22, 2025
26 checks passed
@github-actions
Copy link

Hi @RoyAc6!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@XenuIsWatching XenuIsWatching XenuIsWatching approved these changes

@tejlmand tejlmand tejlmand approved these changes

@57300 57300 Awaiting requested review from 57300

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@tejlmand tejlmand

Labels

area: Build System size: XS A PR changing only a single line of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RoyAc6 @nashif @XenuIsWatching @tejlmand @cfriedt @zephyrbot